Increase lower bound tolerance of future deref timeout test #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address an unexplained descrepancy observed when running the test on GH CI
chrisrink10
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please review to increase the lower bounder tolerance for the
futuredereftest with a timeout period. It addresses #1184.The samples for the CI test failures suggested that the failures had an error of -4ms, so I've increased the lower boundary to 95ms from 100ms. If this proves to be insufficient, I will further increase it to 90ms.
I've also corrected the labelling from
mstos(for seconds), the unitperf-counterreturns.I have not included this in the CHANGELOG, since I think is not required.